Skip to content

Activate TestBed for NativeScript Angular Apps #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Activate TestBed for NativeScript Angular Apps #1139

wants to merge 1 commit into from

Conversation

hypery2k
Copy link
Contributor

@hypery2k hypery2k commented Dec 24, 2017

This adds support for jasmine/mocha angular testing using the TestBed class exported by Angular.

Fixes: #752, #479, #606

  • Zone.js loads appropriate patches for jasmine/mocha
  • Existing tests switched to TestBed from TestApp
  • TestBed specs passing

Updated Version of #1061

Also this needs to be resolved: #NativeScript/zone.js#1

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

9 similar comments
@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ns-bot
Copy link

ns-bot commented Dec 24, 2017

Can one of the admins verify this patch?

@ghost ghost added the ♥ community PR label Dec 24, 2017
@justindujardin
Copy link

justindujardin commented Dec 24, 2017

Are you kidding me? Please close this blatant hijacking of my hard work. If there is something that needs updating with my PR, please comment there and I will update it.

@hypery2k
Copy link
Contributor Author

sorry, got we wrong. Just wanted to rebased. Doesn't want to overtake your work

@hypery2k
Copy link
Contributor Author

sorry

@hypery2k hypery2k closed this Dec 24, 2017
@justindujardin
Copy link

Arg, yeah no problem. I'm sensitive because that took a lot of work. I rebased the PR branch for you. 👍

@hypery2k
Copy link
Contributor Author

I was a the train and just tried your changes. Don't want to got the earnings for your work. I really pleased your work. Would be great to have TestBed in NativeScript. I currently try to speed up the nativescript-angular ci build.

But for now, merry christmas

@justindujardin
Copy link

Hey, thanks for the kind words. :)

I have spoken with @vakrilov about TestBed at length, he's also excited, so I'm sure it will get merged sometime after the new year.

I hope you enjoy your holidays and such.

@hypery2k
Copy link
Contributor Author

Thanks, wish you also great holidays and let’s make NativeScript better ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants