-
-
Notifications
You must be signed in to change notification settings - Fork 241
Activate TestBed for NativeScript Angular Apps #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
9 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Are you kidding me? Please close this blatant hijacking of my hard work. If there is something that needs updating with my PR, please comment there and I will update it. |
sorry, got we wrong. Just wanted to rebased. Doesn't want to overtake your work |
sorry |
Arg, yeah no problem. I'm sensitive because that took a lot of work. I rebased the PR branch for you. 👍 |
I was a the train and just tried your changes. Don't want to got the earnings for your work. I really pleased your work. Would be great to have TestBed in NativeScript. I currently try to speed up the nativescript-angular ci build. But for now, merry christmas |
Hey, thanks for the kind words. :) I have spoken with @vakrilov about TestBed at length, he's also excited, so I'm sure it will get merged sometime after the new year. I hope you enjoy your holidays and such. |
Thanks, wish you also great holidays and let’s make NativeScript better ;) |
This adds support for jasmine/mocha angular testing using the TestBed class exported by Angular.
Fixes: #752, #479, #606
Updated Version of #1061
Also this needs to be resolved: #NativeScript/zone.js#1